You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In notebook, we allow users to insert cells at the top of the document through a toolbar (+ Code, + Markdown)
The toolbar is part of a list item, so to support it we need some padding at the top of the list view. However, we didn't put the top padding on the outer container of the list widget because when the user scrolls the list view, we want the toolbar to move out of view.
Our current approach is very "hacky", we put a top padding on the scrollable element div of the list view. The catch with this approach is that when users navigate in the list view, the list item doesn't always fully reveal itself (it's off by ${top_padding}px).
Proposal
Ideally, we would like to implement a setting similar to Monaco Editor's editor.padding.top in the list view. Monaco editor allows us to customize both the top and bottom padding (editor.padding.top, editor.padding.bottom), currently we can already customize the bottom padding by changing listOptions.additonalScrollHeight but there isn't a way to customize the top.
The text was updated successfully, but these errors were encountered:
We now can set list view's top padding directly instead of our hack of CSS. This means we can programmatically update the padding based on the height of sticky scroll. cc @Yoyokrazy
In notebook, we allow users to insert cells at the top of the document through a toolbar (
+ Code
,+ Markdown
)The toolbar is part of a list item, so to support it we need some padding at the top of the list view. However, we didn't put the top padding on the outer container of the list widget because when the user scrolls the list view, we want the toolbar to move out of view.
Our current approach is very "hacky", we put a top padding on the scrollable element div of the list view. The catch with this approach is that when users navigate in the list view, the list item doesn't always fully reveal itself (it's off by
${top_padding}px
).Proposal
Ideally, we would like to implement a setting similar to Monaco Editor's
editor.padding.top
in the list view. Monaco editor allows us to customize both the top and bottom padding (editor.padding.top
,editor.padding.bottom
), currently we can already customize the bottom padding by changinglistOptions.additonalScrollHeight
but there isn't a way to customize the top.The text was updated successfully, but these errors were encountered: