Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scss] don't offer html tags inside rule sets. #17578

Closed
leighkendell opened this issue Dec 20, 2016 · 2 comments
Closed

[scss] don't offer html tags inside rule sets. #17578

leighkendell opened this issue Dec 20, 2016 · 2 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@leighkendell
Copy link

  • VSCode Version: 1.8.1
  • OS Version: macOS 10.12.2

Steps to Reproduce:

  1. Edit a SCSS file
  2. Observe quick suggestions when typing a CSS property

When typing a property in a SCSS file the suggestions shown also include HTML elements like "h1, h2, p" etc. This is not the same behaviour as when editing CSS or LESS files.

CSS File
image

SCSS File
image

Is it possible to prevent this behaviour in SCSS files?

@egamma egamma added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Dec 20, 2016
@aeschli
Copy link
Contributor

aeschli commented Dec 31, 2016

That's because of nested rulesets in SCSS.

div {
  span {
     color: red;
  }
}

selects all spans inside divs.

There's currently no way of blocking such proposals.

@aeschli aeschli added the feature-request Request for new features or functionality label Dec 31, 2016
@aeschli aeschli changed the title SCSS quick suggestions includes HTML elements [scss] don't offer html tags inside rule sets. Dec 31, 2016
@aeschli aeschli added this to the Backlog milestone Dec 31, 2016
@leighkendell
Copy link
Author

I understand that @aeschli but I still find it weird that it's offering quick suggestions for elements at all inside an SCSS file. I actually thought Atom didn't do this but it turns out it does, perhaps it would make more sense to change the ordering so that all CSS properties show before element suggestions?

@aeschli aeschli modified the milestones: April 2017, Backlog Apr 21, 2017
@aeschli aeschli added the verification-needed Verification of issue is requested label Apr 25, 2017
@isidorn isidorn added the verified Verification succeeded label Apr 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants