Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: links in Quick Input Box #174700

Closed
2 tasks done
TylerLeonhardt opened this issue Feb 17, 2023 · 0 comments
Closed
2 tasks done

Test: links in Quick Input Box #174700

TylerLeonhardt opened this issue Feb 17, 2023 · 0 comments

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Feb 17, 2023

Refs: #82112

Complexity: 2

Create Issue


This milestone we added support for markdown links in Input Boxes:

image
and
image

This works similarly to notifications.

How to test

Prereqs

  • If you're testing from an extension, find an activate function in an extension and just add some code there or create a new extension (no proposed api needed)
  • If you're testing from Core, find a place in the code that already uses the IQuickInputService and just add some code there to play around with the API

For the Steps section below, I want you to try it out in both the "simple" and "complex" API:

  • Simple in Core is the input API
  • Complex in Core is the createInputBox API
  • Simple in Ext is the vscode.window.showInputBox API
  • Complex in Ext is the vscode.window.createInputBox API

Steps

  • For the simple ones, you'll want to:
    • set the prompt to something with a [asdf](https://github.com) link in it.
    • use the validateInput function to return something that has a string with a [asdf](https://github.com) link in it. Try all the different return options
  • For the complext ones, you'll want to:
    • set the prompt to something with a [asdf](https://github.com) link in it.
    • set the validationMessage to something that has a string with a [asdf](https://github.com) link in it. Try all the different return options

You should be able to see the link with an underline, click on it, and tab to it.

@TylerLeonhardt TylerLeonhardt added this to the February 2023 milestone Feb 17, 2023
@ghost ghost assigned ulugbekna and bamurtaugh Feb 21, 2023
@ulugbekna ulugbekna removed their assignment Feb 21, 2023
@bamurtaugh bamurtaugh removed their assignment Feb 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants
@TylerLeonhardt @ulugbekna @bamurtaugh and others