-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use regular button widths for walkthroughs? #166663
Comments
For consistency across the steps and usability (larger touch target), I would recommend that the buttons stay the way they are. If your concern is that the button doesn't appear much like a button, perhaps we can change up the shape/other properties to make its clickable affordance more prominent? Either way, we should keep it consistent across the product. Currently, the buttons which show up in the sidebars are also full width. |
No strong feelings on this one. Smaller button do make it look a bit more approachable and less heavy. As @bhavyaus said, the Welcome view in the sidebar also use full-width buttons (with a max width). |
Not necessarily. I think that was from an earlier proposal to make it more obvious for users that they can proceed to the next step. @digitarald may know why it ultimately didn't make it in? |
Space was one consideration and in the beginning Next also checked items off which didn't seem right. If we drop the todo-aspects (the circle/checkbox in the top-left), bringing back Next makes more sense. It also helps to have steps that don't have actions but are informational. |
I have an issue open for that. #166038. Added a comment to consider adding a Next button there. |
Very good point. I've seen this need across various extensions. 👍 for adding an explicit 'Next' action if the steps are marked done once viewed. |
Ref #165846
I sometimes wonder if the 100% width buttons aren't all that obvious as buttons. FWIW, I'm thinking about the same for buttons in Views (e.g.
Open Folder
).What if we did this for walkthroughs? Thoughts @bhavyaus @digitarald?
The text was updated successfully, but these errors were encountered: