Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regular button widths for walkthroughs? #166663

Closed
daviddossett opened this issue Nov 18, 2022 · 8 comments · Fixed by #166664
Closed

Use regular button widths for walkthroughs? #166663

daviddossett opened this issue Nov 18, 2022 · 8 comments · Fixed by #166664
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@daviddossett
Copy link
Contributor

Ref #165846

I sometimes wonder if the 100% width buttons aren't all that obvious as buttons. FWIW, I'm thinking about the same for buttons in Views (e.g. Open Folder).

What if we did this for walkthroughs? Thoughts @bhavyaus @digitarald?

CleanShot 2022-11-17 at 16 47 11

@bhavyaus
Copy link
Collaborator

bhavyaus commented Nov 18, 2022

For consistency across the steps and usability (larger touch target), I would recommend that the buttons stay the way they are.

If your concern is that the button doesn't appear much like a button, perhaps we can change up the shape/other properties to make its clickable affordance more prominent?
We should also consider setting guidelines around the length of the text in those buttons.

Either way, we should keep it consistent across the product. Currently, the buttons which show up in the sidebars are also full width.

@digitarald
Copy link
Contributor

No strong feelings on this one. Smaller button do make it look a bit more approachable and less heavy.

As @bhavyaus said, the Welcome view in the sidebar also use full-width buttons (with a max width).

@daviddossett
Copy link
Contributor Author

FWIW I actually think the 100% width buttons are not intentional in this case. From the actual designs:

CleanShot 2022-11-18 at 12 00 06@2x

The sidebar feels like a special case to me—we don't show the behavior anywhere else AFAIK.

@bhavyaus
Copy link
Collaborator

FWIW I actually think the 100% width buttons are not intentional in this case. From the actual designs:

CleanShot 2022-11-18 at 12 00 06@2x

The sidebar feels like a special case to me—we don't show the behavior anywhere else AFAIK.

I'm ok either way. Are you also recommending that we bring the Next button back?

@daviddossett
Copy link
Contributor Author

Are you also recommending that we bring the Next button back?

Not necessarily. I think that was from an earlier proposal to make it more obvious for users that they can proceed to the next step. @digitarald may know why it ultimately didn't make it in?

@digitarald
Copy link
Contributor

may know why it ultimately didn't make it in?

Space was one consideration and in the beginning Next also checked items off which didn't seem right.

If we drop the todo-aspects (the circle/checkbox in the top-left), bringing back Next makes more sense. It also helps to have steps that don't have actions but are informational.

@bhavyaus
Copy link
Collaborator

may know why it ultimately didn't make it in?

Space was one consideration and in the beginning Next also checked items off which didn't seem right.

If we drop the todo-aspects (the circle/checkbox in the top-left), bringing back Next makes more sense. It also helps to have steps that don't have actions but are informational.

I have an issue open for that. #166038. Added a comment to consider adding a Next button there.

@daviddossett
Copy link
Contributor Author

daviddossett commented Nov 18, 2022

It also helps to have steps that don't have actions but are informational.

Very good point. I've seen this need across various extensions.

👍 for adding an explicit 'Next' action if the steps are marked done once viewed.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@digitarald @bhavyaus @daviddossett and others