Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move built-in libraries off vscode-nls and on to the l10n API #166305

Closed
5 tasks done
TylerLeonhardt opened this issue Nov 14, 2022 · 1 comment · Fixed by #170188
Closed
5 tasks done

Move built-in libraries off vscode-nls and on to the l10n API #166305

TylerLeonhardt opened this issue Nov 14, 2022 · 1 comment · Fixed by #170188
Assignees
@TylerLeonhardt @rzhao271
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) on-testplan
Milestone
January 2023

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Nov 14, 2022 •
edited by rzhao271
Loading

Similar to #164438 but for libraries...

Here are the docs for @vscode/l10n:
https://github.com/microsoft/vscode-l10n/tree/main/l10n
@TylerLeonhardt TylerLeonhardt added this to the November 2022 milestone Nov 14, 2022
@mjbvz mjbvz mentioned this issue Nov 14, 2022
Merged
@mjbvz mjbvz removed their assignment Nov 14, 2022
@rzhao271 rzhao271 modified the milestones: November 2022, December 2022 Nov 22, 2022
@aeschli
Copy link
Contributor

aeschli commented Dec 5, 2022

The HTML/CSS/JSON services are now all using @vscode/l10n.

#168111 adds the code to configure the servers with location of the localization bundle

@rzhao271 rzhao271 added the debt Code quality issues label Dec 5, 2022
@TylerLeonhardt TylerLeonhardt added the l10n-platform Localization platform issues (not wrong translations) label Dec 5, 2022
@TylerLeonhardt TylerLeonhardt mentioned this issue Dec 6, 2022
Closed
@aeschli aeschli mentioned this issue Dec 9, 2022
Closed
@aeschli aeschli removed their assignment Dec 19, 2022
@rzhao271 rzhao271 mentioned this issue Dec 28, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 28, 2022
@TylerLeonhardt TylerLeonhardt mentioned this issue Jan 23, 2023
Closed
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

@rzhao271 rzhao271

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) on-testplan
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Upgrade emmet-helper microsoft/vscode
5 participants
@TylerLeonhardt @aeschli @rzhao271 @mjbvz @vscodenpa