Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test newly introduced Sublime commands #16545

Closed
3 tasks done
rebornix opened this issue Dec 5, 2016 · 1 comment
Closed
3 tasks done

Test newly introduced Sublime commands #16545

rebornix opened this issue Dec 5, 2016 · 1 comment

Comments

@rebornix
Copy link
Member

rebornix commented Dec 5, 2016

Test #15787

Complexity 4

Overview

We received a bunch of feature requests for Sublime and Atom commands, which are tracked in #3776 and #14316. Now we added 4 of them this sprint.

Join Lines

Verify

  • If there is no trailing spaces in the first line, the leading spaces/tabs will be removed when we run Join Lines (ctrl+j). Besides, we'll put a single cursor between the content of first and second line, and the final cursor will be after the added single space.
  • If there are trailing spaces in the first line, they will be removed when we run Join Lines.
  • Select several lines, run Join Lines, make sure there are only one single space between the content of selected lines. Besides, the start or end of the selection doesn't change (means they are still on the same character).

Transpose

We follow Sublime 3's behavior

Setup

  • We don't assign keybindings for this command as the one ppl use in Sublime is already taken in Code by other commands. Add below config or whatever you like to your settings file.
{
    "key": "ctrl+t",
    "command": "editor.action.transpose"
}

Verify

  • We can transpose space and tabs
  • We can not transpose when the line is empty
  • We can not transpose when the cursor is at the end of the line
  • When the cursor is at the beginning of a line and the content of current line is not empty, running Transpose will just move the cursor to column 2 (1 based).

Upper/Lower Case

Setup

  • We don't assign keybindings for this command as the one ppl use in Sublime is already taken in Code by other commands. Add below config or whatever you like to your settings file.
{
    "key": "ctrl+u",
    "command": "editor.action.transformToUppercase"
},
{
    "key": "ctrl+l",
    "command": "editor.action.transformToLowercase"
}

Verify

  • If there is selection, selected text are transformed to Upper/Lower case.
  • If there is no selection and the cursor is inside a word, the word is transformed to Upper/Lower case.
  • Cursor or selection doesn't change.

Please note that the boundary of a word is determined by the language mode.

@rebornix rebornix added this to the November 2016 milestone Dec 5, 2016
@dbaeumer dbaeumer removed their assignment Dec 6, 2016
@thekalinga
Copy link

Can the shortcut be added to toggle case along with upper and lowercase, as this makes life easier to have just one shortcut to toggle case.

Which is what IDEA follows

@bpasero bpasero removed their assignment Dec 6, 2016
@weinand weinand removed their assignment Dec 6, 2016
@aeschli aeschli removed their assignment Dec 6, 2016
@aeschli aeschli closed this as completed Dec 6, 2016
@weinand weinand self-assigned this Dec 7, 2016
@weinand weinand added verified Verification succeeded and removed verified Verification succeeded labels Dec 7, 2016
@weinand weinand removed their assignment Dec 7, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants