Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test task reconnection: expected behavior on reload of killed task? #158964

Closed
andreamah opened this issue Aug 23, 2022 · 2 comments
Closed

Test task reconnection: expected behavior on reload of killed task? #158964

andreamah opened this issue Aug 23, 2022 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Milestone
September 2022

Comments

@andreamah
Copy link
Contributor

Testing #158787

repro:

  1. run the VS Code - Build task
  2. use CTRL+D to stop both tasks (should say "Terminal will be reused by tasks, press any key to close it.")
  3. reload the window
  4. tasks start running again ❓

Not too sure what the expected behavior should be on this, but it thought that it would reload at the same state (task stopped or not even there).
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal-persistence Relating to process reconnection or process revive labels Aug 23, 2022
@meganrogge
Copy link
Contributor

Good find - the tasks should not be re-run in this case and need to be removed from persistent tasks

@meganrogge meganrogge added this to the September 2022 milestone Aug 23, 2022
@meganrogge
Copy link
Contributor

@andreamah I can't reproduce this anymore - pls reopen this if you can

@andreamah andreamah added the verified Verification succeeded label Aug 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

No branches or pull requests
3 participants
@Tyriar @meganrogge @andreamah