Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer if we should pre-seed TS typings with the tsserver #15536

Closed
dbaeumer opened this issue Nov 15, 2016 · 2 comments
Closed

Explorer if we should pre-seed TS typings with the tsserver #15536

dbaeumer opened this issue Nov 15, 2016 · 2 comments
Assignees
@dbaeumer
Labels
plan-item VS Code - planned item for upcoming typescript Typescript support issues
Milestone
November 2016

Comments

@dbaeumer
Copy link
Member

  • VSCode Version: 1.8.x

Currently typings are fetch from npm. We shouldexplore the option to pre-seed a set of typings with the tsserver to avoid npm requests.
@dbaeumer dbaeumer added this to the November 2016 milestone Nov 15, 2016
@dbaeumer dbaeumer added typescript Typescript support issues plan-item VS Code - planned item for upcoming labels Nov 15, 2016
@dbaeumer dbaeumer self-assigned this Nov 15, 2016
@dbaeumer
Copy link
Member Author

Since npm caches modules and we need to check for a newer version anyways it might not make too much sense to add another cache. Makes things only more complicated.

@kieferrm kieferrm mentioned this issue Nov 15, 2016
Closed
@dbaeumer
Copy link
Member Author

dbaeumer commented Dec 2, 2016

Done. We decided to not pressed typings.

@dbaeumer dbaeumer closed this as completed Dec 2, 2016
@egamma egamma mentioned this issue Dec 20, 2016
Closed
56 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
plan-item VS Code - planned item for upcoming typescript Typescript support issues
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
1 participant
@dbaeumer