Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support playing of mono/stereo np.array waveform in cell output #151149

Closed
p-i- opened this issue Jun 2, 2022 · 4 comments
Closed

Support playing of mono/stereo np.array waveform in cell output #151149

p-i- opened this issue Jun 2, 2022 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality notebook-output
Milestone

Comments

@p-i-
Copy link

p-i- commented Jun 2, 2022

I perform work as an audio/DSP engineer.

I generate waveforms in Notebook cells, and use display( Audio( waveform, rate=SAMPLERATE ) ) where waveform is a 1D or 2D numpy.array

This works in Jupyter Notebook (browser-based) but not in VSCode's .ipynb editor.

Numerous issues have been filed, e.g. microsoft/vscode-jupyter#1012 (116 upvotes) and #118275 (176 upvotes).

This is a gaping hole in an exquisitely engineered product.

The conversation cites difficulties with ffmpeg, possibly licensing issues. I can find no clear exposition of what the blocker is.

Could we please have, as a stopgap, a basic functionality for playing a mono/stereo numpy.array from a cell output?

This will yield massive bang-for-buck -- engineers will be able to use their initiative to convert audio into raw numpy arrays, and... achievement unlocked.

Please could your team consider prioritizing this?

@lukepighetti
Copy link

This makes a lot of sense. I am happy to do the conversion with code and accept the license terms for ffmpeg on my own. All I need is for VSCode to play raw signals that's in a numpy array.

@rebornix rebornix added the feature-request Request for new features or functionality label Jun 27, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Jun 27, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@rebornix
Copy link
Member

This is now available in latest Insiders and the upcoming Stable release.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook-output
Projects
None yet
Development

No branches or pull requests

6 participants