Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension item height could be larger #150449

Closed
isidorn opened this issue May 26, 2022 · 6 comments · Fixed by #169297
Closed

Extension item height could be larger #150449

isidorn opened this issue May 26, 2022 · 6 comments · Fixed by #169297
Assignees
Labels
extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented May 26, 2022

While helping Marketplace improve extension search I noticed that for most queries there are no more than 5 good results.
And we currently show an infinite list which depending on Monitor size would show 10 - 20 extensions.
Also we sometimes struggle with the small size of extension items in the list - not enough space for all the decorations we would like to render.

Based on the two above, I suggest we explore with increasing the vertical size of the extension items in the list.
Ideally this would allow to present the information in a cleaner way when users search for extensions.

I am not sure how this would effect the list of installed and recommended extensions. Ideally we would also increase the size of those to be consistent, but for those cases I am not convinced if it would be a win.

@sandy081 what do you think?

@daviddossett @misolori for ux thoughts

Example from my screen

Screenshot 2022-05-26 at 15 45 18

@isidorn isidorn added extensions Issues concerning extensions under-discussion Issue is under discussion for relevance, priority, approach labels May 26, 2022
@daviddossett
Copy link
Contributor

From a visual standpoint it makes sense to explore giving these some breathing room. As far as solving for quality results, I don't know if making them bigger will necessarily solve that problem alone. It could be that we have a sort of "Top Results" section up top with the remaining results in another section. Just one idea off the top of my head.

@sandy081
Copy link
Member

I agree its worth exploring it give more space for an extension in the viewlet. But this might impact if the size of the screen is smaller.

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Dec 5, 2022
@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
@esonnino esonnino reopened this Dec 15, 2022
esonnino added a commit that referenced this issue Dec 16, 2022
Increase height of items in Extensions list - Fix #150449
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Dec 16, 2022
@vscodenpa vscodenpa added this to the January 2023 milestone Dec 16, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 19, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Dec 19, 2022

I see this is merged and should be latest VS Code Insiders but I do not see any changes in my VS Code Insiders.
@esonnino am I missing something here?

@daviddossett
Copy link
Contributor

@isidorn I'm seeing the latest after updating:

Before

CleanShot 2023-01-03 at 08 48 48@2x

Current

CleanShot 2023-01-03 at 08 49 32@2x

@isidorn
Copy link
Contributor Author

isidorn commented Jan 3, 2023

@daviddossett I just got the update. Looks ok to me - I will need some time to adjust.
Let's see what insiders users and the rest of the team says :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants