Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush local history before shutdown when connected to a remote #146554

Closed
bpasero opened this issue Apr 1, 2022 · 3 comments
Closed

Flush local history before shutdown when connected to a remote #146554

bpasero opened this issue Apr 1, 2022 · 3 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders remote Remote system operations issues timeline-local-history verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2022

Comments

@bpasero
Copy link
Member

bpasero commented Apr 1, 2022 •
edited
Loading

Because the remote connection can drop at any time, it is somewhat dangerous to flush local history only on shutdown.

Refs: https://github.com/github/codespaces/issues/7228
@bpasero bpasero added feature-request Request for new features or functionality remote Remote system operations issues timeline-local-history labels Apr 1, 2022
@bpasero bpasero added this to the April 2022 milestone Apr 1, 2022
@bpasero bpasero self-assigned this Apr 1, 2022
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@bpasero bpasero closed this as completed in ff7237a Apr 5, 2022
@bpasero bpasero added the verification-needed Verification of issue is requested label Apr 5, 2022
@bpasero
Copy link
Member Author

bpasero commented Apr 19, 2022

@jkeech can you verify this using insiders with Codespaces? Thanks!

@bpasero
Copy link
Member Author

bpasero commented Apr 19, 2022

Verification:

  • open timeline for a file
  • save the file and notice a local history entry
  • edit the entry, give it a different name
  • disconnect from the remote
  • connect again and ensure the history entry name is still there

@jkeech
Copy link
Member

jkeech commented Apr 19, 2022

Verified on Insiders in Codespaces. Thanks for the fix! ❤️

@bpasero bpasero added the verified Verification succeeded label Apr 20, 2022
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders remote Remote system operations issues timeline-local-history verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
3 participants
@jkeech @bpasero and others