Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes of tsconfig not updates error #14524

Closed
willi84 opened this issue Oct 26, 2016 · 5 comments
Closed

changes of tsconfig not updates error #14524

willi84 opened this issue Oct 26, 2016 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@willi84
Copy link

willi84 commented Oct 26, 2016

  • VSCode Version: 1.6.1
  • OS Version: Win10

Steps to Reproduce:

  1. have an error like Getting an error for experimental support for decorators with experimentalDecorators enabled TypeScript-Sublime-Plugin#470 (https://twitter.com/robertSPD/status/790950380570087424)
  2. update tsconfig but error-tooltip is not leaving
  3. need to restart for update

it would cool, if changes are loaded without restart

@waderyan
Copy link

@willi84 thank you for opening this issue. Can you share your workspace so we can recreate this on our machines?

@dbaeumer it seems this is being provided by the language service... we just aren't kicking off the refresh until the file is reloaded.

@waderyan waderyan added javascript JavaScript support issues typescript Typescript support issues info-needed Issue requires more information from poster and removed javascript JavaScript support issues labels Oct 26, 2016
@dbaeumer
Copy link
Member

@waderyan we do re-ask for all errors after waiting for 1.5 seconds. The problem however might be that the tsserver didn't process the file event in that time frame. To make this work nicely the tsserver either needs to sent and event when the [jt]sconfig.json changes or needs to retrigger error computation (builder work) by itself when these file change.

@waderyan
Copy link

@dbaeumer thank you. To confirm - microsoft/TypeScript#11229 will solve this for OP?

@dbaeumer
Copy link
Member

dbaeumer commented Nov 1, 2016

yes.

@waderyan
Copy link

waderyan commented Nov 2, 2016

Closing as dup of microsoft/TypeScript#11229

@waderyan waderyan closed this as completed Nov 2, 2016
@waderyan waderyan added *duplicate Issue identified as a duplicate of another issue(s) and removed info-needed Issue requires more information from poster typescript Typescript support issues labels Nov 2, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants