Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal search improve #144371

Closed
ladyrick opened this issue Mar 4, 2022 · 3 comments
Closed

Terminal search improve #144371

ladyrick opened this issue Mar 4, 2022 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@ladyrick
Copy link

ladyrick commented Mar 4, 2022

Vscode terminal use 'text selection' to emulate 'search highlight'. This fact is the reason to:

  1. Search highlight will always show at most one result even if there are many results in terminal text.
  2. After a search, once I focused on the terminal cursor, the highlighted search result is no longer highlighted.
  3. (the direct proof) The only way to change terminal search highlight color is to change this setting: "terminal.selectionBackground". As you can see, this setting is intend to control the selection color instead of search highlight color.

I want vscode to implement the real search highlight, just like what iTerm2 do:
image

@yume-chan
Copy link
Contributor

Duplicate of #134790

@meganrogge
Copy link
Contributor

/duplicate #134790

@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants
@yume-chan @ladyrick @meganrogge and others