Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active indicator is misaligned on Windows in maximized mode #140723

Closed
miguelsolorio opened this issue Jan 14, 2022 · 2 comments
Closed

Active indicator is misaligned on Windows in maximized mode #140723

miguelsolorio opened this issue Jan 14, 2022 · 2 comments
Assignees
@miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded windows VS Code on Windows issues
Milestone
January 2022

Comments

@miguelsolorio
Copy link
Contributor

Related to #140647

image

image

(screenshots are hard to see but there is a gap between the active indicator in the explorer)

When in maximized mode on Windows, the windowless px is gone and the indicator gets mis-aligned. We need a way to not let the indicator misalign in maximized mode so we'll look at toggling a class when in maximized mode.

cc @sbatten
@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug windows VS Code on Windows issues labels Jan 14, 2022
@miguelsolorio miguelsolorio added this to the January 2022 milestone Jan 14, 2022
@miguelsolorio miguelsolorio self-assigned this Jan 14, 2022
@sbatten
Copy link
Member

sbatten commented Jan 14, 2022

added class with 050dd09

@miguelsolorio
Copy link
Contributor Author

For verification: verify that there is no gap between the active indicator in the activity bar while in maximized mode

@rzhao271 rzhao271 added the verified Verification succeeded label Jan 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
January 2022
Development

No branches or pull requests
4 participants
@sbatten @rzhao271 @miguelsolorio and others