Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extensions to disable the "Open Preview to the Side" button for markdown preview #136388

Closed
SeriousBug opened this issue Nov 3, 2021 · 5 comments
Closed

Allow extensions to disable the "Open Preview to the Side" button for markdown preview #136388

SeriousBug opened this issue Nov 3, 2021 · 5 comments
Assignees
@mjbvz
Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2021

Comments

@SeriousBug
Copy link
Contributor

VSCode automatically adds a "Open Preview to the Side" button which displays the default markdown preview when the button is pressed. This can be confusing for extensions like Markdown Preview Enhanced and Dendron which add custom markdown previews.

I suggest adding a mechanism for extensions to disable the default button. The extensions then can add their own buttons, or leave the preview button removed.

#136273
@mjbvz mjbvz self-assigned this Nov 3, 2021
@SeriousBug SeriousBug mentioned this issue Nov 3, 2021
Merged
@mjbvz mjbvz added author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality labels Nov 3, 2021
@mjbvz mjbvz added this to the November 2021 milestone Nov 3, 2021
@mjbvz
Copy link
Collaborator

mjbvz commented Nov 3, 2021

Fixed by #136273

@mjbvz mjbvz closed this as completed Nov 3, 2021
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Nov 29, 2021
@DonJayamanne DonJayamanne added the verified Verification succeeded label Dec 1, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Dec 1, 2021

Looks good as far as the button being disabled, but should this be disabled too?

image

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 7, 2021

Thanks for testing. @SeriousBug Do you also want to submit a PR that handles the editor context menus? Not sure if you see users being confused by those as well

@SeriousBug
Copy link
Contributor Author

SeriousBug commented Dec 7, 2021 •
edited
Loading

@mjbvz Haven't seen users confused by that yet, but it makes sense for this option to apply to that as well. I'll look into this and create another issue & PR, thanks for the suggestion!

@SeriousBug SeriousBug mentioned this issue Dec 15, 2021
Closed
@SeriousBug
Copy link
Contributor Author

@mjbvz @rchiodo I have a PR up for this!

#139241

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
4 participants
@SeriousBug @DonJayamanne @mjbvz @rchiodo