Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks - Make default for Jupyter NB toolbar icon as opposed to icon + label #134248

Closed
claudiaregio opened this issue Sep 30, 2021 · 2 comments
Assignees
Labels
notebook-globaltoolbar notebook-workflow Issues that interrupt expected or desirable behavior on-testplan under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone

Comments

@claudiaregio
Copy link

This request comes from the discussion started on this PR: microsoft/vscode-jupyter#7651

The outline icon was added to the global toolbar in an effort to help discoverability. With now 8 icons in the toolbar and this being added as the last, depending on the screen size this icon is more likely to end up in the overflow menu and may reduce some of the effectiveness at improving discoverability.

For other languages too, the toolbar can get really long with the text.
image

@claudiaregio claudiaregio added the under-discussion Issue is under discussion for relevance, priority, approach label Sep 30, 2021
@greazer greazer added this to the October 2021 milestone Oct 12, 2021
@rebornix rebornix added notebook-globaltoolbar ux User experience issues labels Oct 21, 2021
@rebornix rebornix modified the milestones: October 2021, On Deck Oct 21, 2021
@greazer
Copy link
Member

greazer commented Oct 26, 2021

After discussion, suggestion was to create a hybrid model. If there's enough space for text and an icon, then use it. As the window narrows, text labels are removed. If all the buttons don't fit, then the overflow is populated.

@greazer greazer added the notebook-workflow Issues that interrupt expected or desirable behavior label Oct 26, 2021
@claudiaregio
Copy link
Author

For this hybrid model, variable explorer and outline are visible correct?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook-globaltoolbar notebook-workflow Issues that interrupt expected or desirable behavior on-testplan under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants
@rebornix @DonJayamanne @greazer @claudiaregio and others