Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does it makes sense that files.watcherInclude can be configured for a workspace? #134145

Closed
TylerLeonhardt opened this issue Sep 29, 2021 · 1 comment
Closed

Does it makes sense that files.watcherInclude can be configured for a workspace? #134145

TylerLeonhardt opened this issue Sep 29, 2021 · 1 comment
Assignees
@bpasero
Labels
file-watcher File watcher

Comments

@TylerLeonhardt
Copy link
Member

Testing #133753

Is there a scenario where this makes sense? Just an open question.
@bpasero
Copy link
Member

bpasero commented Sep 30, 2021

Yeah I think it does: if someone wants to check-in this configuration because a workspace is known to have symlinks then this would allow a nice self-contained experience, not requiring users having to configure that.

I didn't want to artificially limit the setting to global scope.

@bpasero bpasero closed this as completed Sep 30, 2021
@bpasero bpasero added the file-watcher File watcher label Sep 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
file-watcher File watcher
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpasero @TylerLeonhardt