Option onExit in terminal.integrated.persistentSessionReviveProcess also restores terminal buffer when window is closed and then reopened

[karrtikr]

Testing #133516

There're two options: onExitAndWindowClose and onExit, both seem to be working the some way. I'm assuming if I close the Window using Close Window command, onExit should not apply and only onExitAndWindowClose should.

[meganrogge]

is it the last window that you are closing? if so, according to the description, it should restore.

[karrtikr]

I'm using Close window command, which apparently closes every tab and exits VSCode. What is meant by a "window" here and how to close it?

[meganrogge]

meaning if you have several vscode windows open then closing and reopening that window with onExit set, shouldn't restore (according to the setting description).

but if you have only one vscode window open and you close and re-open it, then it should restore the terminals

[karrtikr]

Ah I see, thanks. Can you tell how do I reopen a window which I just closed?

[meganrogge]

I think VS code will automatically open the last window you had open when you next open the app

[karrtikr]

when you next open the app

That's true, but I only have to close one window (which is not the last window) and so the app will still be open. I guess what I'm asking is how do I restore a single window while other windows and the app are still open?

[meganrogge]

onExit should only restore when 1) all of the windows are closed 2) the last window is closed (not on mac) and reopened
onExitAndWindowClose should restore when any window is closed and reopened

[karrtikr]

onExitAndWindowClose should restore when any window is closed and reopened

I'm not sure how to test this behavior as I'm not clear on how to accomplish the "reopen" part here for any window.

[meganrogge]

@karrtikr let's say you have 3 folders open in separate windows: A, B, C and have onExitAndWindowClose set.

close the window with folder C. in window A or B, go to file -> open recent -> open folder C. the terminal buffers should be restored.

@Tyriar correct this if it's inaccurate please

[meganrogge]

closing this because it's been 7 days since a follow up. if you want to follow up on this, feel free to reopen @karrtikr

[karrtikr]

Apologies for the delay, I can confirm it works fine👍