Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal revive setting feedback #133969

Closed
bpasero opened this issue Sep 28, 2021 · 1 comment
Closed

Terminal revive setting feedback #133969

bpasero opened this issue Sep 28, 2021 · 1 comment
Assignees
Labels
*as-designed Described behavior is as designed polish Cleanup and polish issue terminal General terminal issues that don't fall under another label
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 28, 2021

Testing #133516

I find our setting description and name a bit confusing. Here is macOS for example:

image

Some obersvations:

  • there is a setting to configure whether a marker should be printed 👍
  • the setting does not talk about "persistent session" but "restore text" which I like because that is my understanding of the feature
  • our setting talks about "processes being recreated" but my understanding is that we only restore the lines and not the running processes
@meganrogge meganrogge added terminal General terminal issues that don't fall under another label under-discussion Issue is under discussion for relevance, priority, approach and removed terminal General terminal issues that don't fall under another label labels Sep 28, 2021
@meganrogge meganrogge added this to the October 2021 milestone Sep 28, 2021
@meganrogge meganrogge added the terminal General terminal issues that don't fall under another label label Sep 28, 2021
@Tyriar Tyriar added polish Cleanup and polish issue and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 19, 2021
@Tyriar
Copy link
Member

Tyriar commented Oct 20, 2021

"Persistent sessions" was the existing feature that enabled "process reconnection", the intent in putting it under the same prefix was because they are similar concepts (reconnection to processes across reloads, save the buffer+re-create the processes across restarts).

Let's keep the setting the same for now as the description is fairly descriptive and that will be searched as well when using the settings UI.

our setting talks about "processes being recreated" but my understanding is that we only restore the lines and not the running processes

The processes to get recreated using the same properties as the previous process, except the current working directory that may change depending on the shell/OS.

@Tyriar Tyriar closed this as completed Oct 20, 2021
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Oct 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed polish Cleanup and polish issue terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

3 participants