Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal revive: bad contrast for restore message #133966

Closed
bpasero opened this issue Sep 28, 2021 · 1 comment
Closed

Terminal revive: bad contrast for restore message #133966

bpasero opened this issue Sep 28, 2021 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal General terminal issues that don't fall under another label
Milestone
September 2021

Comments

@bpasero
Copy link
Member

bpasero commented Sep 28, 2021 •
edited
Loading

Testing #133516

Using Default Light theme:

image

I doubt this matches our contrast ratio.

//cc @misolori
@meganrogge meganrogge added polish Cleanup and polish issue terminal General terminal issues that don't fall under another label labels Sep 28, 2021
@meganrogge meganrogge added this to the September 2021 milestone Sep 28, 2021
@miguelsolorio
Copy link
Contributor

This actually does pass the color contrast ratio:

CleanShot 2021-09-28 at 14 49 42@2x

But I think it does feel a bit heavy so going with a lighter bg could be beneficial here. @meganrogge can we use 252 for the bg?

image

@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
September 2021
Development

No branches or pull requests
5 participants
@bpasero @Tyriar @meganrogge @miguelsolorio and others