Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: persistent scrollback session does not work #133965

Closed
bpasero opened this issue Sep 28, 2021 · 1 comment
Closed

Terminal: persistent scrollback session does not work #133965

bpasero opened this issue Sep 28, 2021 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
*as-designed Described behavior is as designed bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member terminal General terminal issues that don't fall under another label

Comments

@bpasero
Copy link
Member

bpasero commented Sep 28, 2021

Testing #133516

I have it configured to 3 but get many more lines restored after a restart:

image
@meganrogge meganrogge added confirmed Issue has been confirmed by VS Code Team member bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label and removed confirmed Issue has been confirmed by VS Code Team member labels Sep 28, 2021
@meganrogge meganrogge added this to the October 2021 milestone Sep 28, 2021
@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2021

I think this was actually acting as designed. Scrollback only refers to the part above the viewport so the restored part would be a maximum of number or rows in viewport + scrollback. This is consistent with the scrollback setting.

@Tyriar Tyriar closed this as completed Oct 25, 2021
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Oct 25, 2021
@Tyriar Tyriar removed this from the October 2021 milestone Oct 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
*as-designed Described behavior is as designed bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpasero @Tyriar @meganrogge