Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support link detection for in notebook error output #132145

Closed
Tracked by #12285
DonJayamanne opened this issue Mar 15, 2021 · 8 comments
Closed
Tracked by #12285

Support link detection for in notebook error output #132145

DonJayamanne opened this issue Mar 15, 2021 · 8 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality notebook-output

Comments

@DonJayamanne
Copy link
Contributor

@nfx commented on Sat Feb 27 2021

Issue Type: Bug

Screenshot 2021-02-27 at 19 15 34

Let's imagine some hypothetical bad code that resulted in exception either because bad or unfamiliar third-party libraries and focus on speed of issue resolution:

import pandas as pd
pd.DataFrame(42)

Upon executing this, we get an exception. As professional IDE user, I expect a consistent behavior and exception stack trace rendered like a normal stack trace - something compact, with clickable lines, that get me to correct lines of code, causing the error. I do not want to open search bar in the project, then figure out that this is not the error in the project i'm working on, but rather in third-party dependency, because that way i have to go, figure out where the sources of that dependency are, open another editor, find references, etc etc. I also really don't want to see the same exception message for 3 times. Practically speaking, we can make hiding of stack traces as opt-out feature. If make with bottom-right notifications popup - even better :)

VSCode has a nice stack trace rendering widget in debug mode, so that one could be just re-used in this beautiful extension, so that I'd see consistent UX across different parts of the editor for the same type of things.

...

Extension version: 2021.3.600686576
VS Code version: Code - Insiders 1.54.0-insider (Universal) (e590188, 2021-02-26T20:39:12.763Z)
OS version: Darwin x64 19.6.0

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt602:30263608
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30244315
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvspyt639:30264824
pythontb:30258533


@nfx commented on Sat Feb 27 2021

Must be part of #91987


@joyceerhl commented on Sat Feb 27 2021

Thanks for the feedback @nfx. Possible dupe of microsoft/vscode-jupyter#4589


@nfx commented on Sun Feb 28 2021

@joyceerhl this one has more details 😜

@vscodebot
Copy link

vscodebot bot commented Mar 15, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@DonJayamanne
Copy link
Contributor Author

@rebornix @jrieken /cc
Feature request.

@jrieken jrieken changed the title Cannot go to sources of exception stack trace Support link detection in notebook error output Mar 16, 2021
@rebornix
Copy link
Member

rebornix commented Aug 2, 2021

Only Jupyter understands the error links correctly, let's do this in the error renderer.

@rebornix rebornix transferred this issue from microsoft/vscode Aug 2, 2021
@greazer greazer changed the title Support link detection in notebook error output Support link detection for in notebook error output Aug 9, 2021
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Sep 2, 2021
@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Sep 2, 2021

Only Jupyter understands the error links correctly

@rebornix
This is not true. We get link detection in terminals today for Python stack traces in terminal outputs (handle by VSCode core). Hence I believe it can be done in core as well.

FYI - This is a feature request from users.

@rebornix rebornix added feature-request Request for new features or functionality notebook-output labels Oct 11, 2021
@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 2, 2022
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2022
@rebornix
Copy link
Member

rebornix commented Dec 2, 2022

Let's track it in microsoft/vscode-jupyter#12285

@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality notebook-output
Projects
None yet
Development

No branches or pull requests

5 participants
@rebornix @jrieken @DonJayamanne @vscodenpa and others