Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked groups: flip the lock icon #131545

Closed
sbatten opened this issue Aug 24, 2021 · 1 comment
Closed

Locked groups: flip the lock icon #131545

sbatten opened this issue Aug 24, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editor-groups Issues related to editor groups
Milestone

Comments

@sbatten
Copy link
Member

sbatten commented Aug 24, 2021

Testing #131196

The locked icon is shown unlocked currently when the current group is locked. I am always confused by whether an icon shows the current status or the status after clicking the button (i.e. the action to take). This is because we are not consistent. It seems we tend to favor action over the status but there are exceptions.

SCM: Show as Tree/List
Shows the action, not the current state
image

Search: Collapse/Expand All
Shows the action, not the current state

Explorer: Filter
Shows the current state, not the action
image

Timeline: Pinned
Shows the current state, not the action
image

GitLens Remotes: Show as Tree/List
Shows the current state, not the action
image

GitLens Search Commits: Keep Results
Shows the current state, not the action
image

Can we establish some guideline here? Maybe cool for the editor lock would be showing as locked until hover indicating that click would unlock the group.

@bpasero
Copy link
Member

bpasero commented Aug 25, 2021

Good catch, I tend to just flip the icon to show the lock because we do the same for pinned tabs:

image

//cc @misolori for the general UX guidance

@bpasero bpasero added the workbench-editor-groups Issues related to editor groups label Aug 25, 2021
@bpasero bpasero added this to the August 2021 milestone Aug 25, 2021
@bpasero bpasero changed the title Should icon reflect current state or action? Locked groups: flip the lock icon Aug 25, 2021
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 25, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editor-groups Issues related to editor groups
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @sbatten @rzhao271 and others