Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket Pair Colorization ToDos #130767

Closed
9 of 13 tasks
hediet opened this issue Aug 13, 2021 · 2 comments
Closed
9 of 13 tasks

Bracket Pair Colorization ToDos #130767

hediet opened this issue Aug 13, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@hediet
Copy link
Member

hediet commented Aug 13, 2021

  • P1 hide customBracketPairs (and in the future merge it with language configuration)
    ITextModelUpdateOptions
    • remove configureBracketPairColorization from view model
  • P1 move backgroundTokenizationCompleted up to BracketPairColorizer: this.initialAstWithoutTokens is not undefined
  • P1 get rid of owners / use attached concept event
  • P1 in PairAstNode, why not have individual members instead of the children array them and handle iterating with the kind, maybe add firstChild / hasChildren
  • P1 hard coded to 3 colors - ColorProvider
  • investigate many instances of InvalidBracketAstNode in sqlite3.c / consider reusing instances
  • P0 introduce some kind of limit for super large files, drive it by having it <100ms
    • a much better solution would be to split the work in 10ms chunks
  • P0 open 1GB file with brackets INSERT STATEMENT () / csv
  • P2 Tokenizer: instead of working off a string, work off a ITextSnapshot
  • P2 a test that tests end-to-end
  • Support readonly tree (copy on write)
@hediet hediet added this to the August 2021 milestone Aug 13, 2021
@hediet hediet self-assigned this Aug 13, 2021
@hediet hediet modified the milestones: August 2021, September 2021 Aug 26, 2021
@hediet hediet modified the milestones: September 2021, October 2021 Sep 30, 2021
@hediet hediet added the debt Code quality issues label Oct 12, 2021
@hediet hediet modified the milestones: October 2021, November 2021 Oct 28, 2021
@hediet hediet modified the milestones: November 2021, On Deck Nov 30, 2021
@pkese
Copy link

pkese commented May 10, 2022

Brackets in some languages are not matched correctly, e.g. in F#:

image

Also #139286

@hediet
Copy link
Member Author

hediet commented Dec 9, 2022

Closing, as the Bracket pair colorization feature is very stable now and the remaining tasks are not needed.

@hediet hediet closed this as completed Dec 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants