Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Interactive Window: Keybinding / Command to move from input box to output history #130724

Closed
IanMatthewHuff opened this issue Aug 12, 2021 · 3 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders interactive-window on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@IanMatthewHuff
Copy link
Member

Does this issue occur when all extensions are disabled?: No (using Jupyter extension for testing)

  • VS Code Version: 1.60 insiders (8/12 build)
  • OS Version: MacOS BigSur

Was dogfooding the new interactive window (testing VIM extension in input box) and I wasn't finding a good way to jump between the output history and the input box without using the mouse. I wanted to be able to move up to the history and scroll back in it, and then jump back down to the input box to put something new in.

image

As a side note, when my focus was on a cell back in the history list, doing shift+enter or ctrl+enter would execute the current contents of the input box. I'm not sure if this is a bug as I'm not 100% sure on what I would have expected there. I might expect that cell I have selected to be rerun?

@connor4312
Copy link
Member

Very similar to #128497, but not an exact duplicate

@joyceerhl joyceerhl removed their assignment Oct 26, 2021
@greazer greazer added the bug Issue identified by VS Code Team member as probable bug label Jan 11, 2022
@greazer
Copy link
Member

greazer commented Jan 11, 2022

I don't really see this as a feature-request but more like a workflow bug. You could argue that it's an accessibility problem as well. Going to add it as a golden-path issue for visibility. We've had a valuable customer recently complain about this.

@greazer greazer modified the milestones: On Deck, February 2022 Jan 11, 2022
@rebornix rebornix modified the milestones: February 2022, March 2022 Feb 23, 2022
@greazer greazer added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Mar 4, 2022
@rebornix
Copy link
Member

rebornix commented Mar 8, 2022

{
  "key": "alt+cmd+up",
  "command": "interactive.history.focus"
},
{
  "key": "alt+cmd+down",
  "command": "interactive.input.focus"
}

Added two commands to focus the history or input editor in the interactive window. Above snippet is keybindings I use.

@rzhao271 rzhao271 added verification-needed Verification of issue is requested verified Verification succeeded labels Mar 22, 2022
@rebornix rebornix added the on-release-notes Issue/pull request mentioned in release notes label Mar 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders interactive-window on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants
@IanMatthewHuff @rebornix @connor4312 @rzhao271 @greazer @joyceerhl and others