Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Terminal editors - Split terminal does not work #127633

Closed
lszomoru opened this issue Jun 30, 2021 · 2 comments
Closed

Test: Terminal editors - Split terminal does not work #127633

lszomoru opened this issue Jun 30, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

Testing #127192

Repro steps:

  1. Open VS Code, and click on "New Terminal" which will open the terminal in the panel
  2. Use the "Move Terminal into the Editor Area" command from the command palette
  3. In the Editor toolbar click on the "Split Editor Right" button
  4. In the Terminal on the right, use the dropdown menu to try to split the terminal

image

Expected behaviour:
Terminal would be split

Actual behaviour:
Nothing happens

What I have noticed is that after step 3) if you select the Terminal on the left, then switch back to the Terminal on the right, and try to do step 4) it seems to work as expected.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-editors labels Jun 30, 2021
@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2021

I can repro unexpected split location because the left most item is focused not the new right one (which is active 🤯).

@Tyriar Tyriar added this to the June 2021 milestone Jun 30, 2021
@meganrogge
Copy link
Contributor

I can't repro this using the above steps or other combinations - I think @Tyriar fixed this with cae22b8

@rzhao271 rzhao271 added the verified Verification succeeded label Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants