Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal editors have no context menu on linux #127619

Closed
weinand opened this issue Jun 30, 2021 · 4 comments
Closed

Terminal editors have no context menu on linux #127619

weinand opened this issue Jun 30, 2021 · 4 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Milestone
June 2021

Comments

@weinand
Copy link
Contributor

weinand commented Jun 30, 2021

Testing #127192

Terminal editors have no context menu on linux:

2021-06-30_10-59-36 (1)

Please note: I'm running ubuntu 21.04 in Parallels.
@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2021

@weinand are you on the latest as the context menu was fixed yesterday, and does changing the rightClickBehavior setting change things?

@Tyriar Tyriar added terminal General terminal issues that don't fall under another label terminal-editors info-needed Issue requires more information from poster labels Jun 30, 2021
@Tyriar Tyriar added this to the June 2021 milestone Jun 30, 2021
@Tyriar Tyriar added the linux Issues with VS Code on Linux label Jun 30, 2021
@weinand
Copy link
Contributor Author

weinand commented Jun 30, 2021

I'm on:
2021-06-30_13-53-09

Changing the setting "rightClickBehavior" to "copyPaste" makes the right mouse button paste immediately. But setting it to "default" does not enable the context menu.

@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2021

Thanks for the extra info, I was having problems getting my linux vm running

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jun 30, 2021
@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2021

Let's copy closer when TerminalView does, in particular remove the e.button check in the ctx menu event handler, remove the other contextmenu event handler and make sure this._cancelContextMenu is checked.

@connor4312 connor4312 added the verified Verification succeeded label Jul 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

No branches or pull requests
5 participants
@weinand @Tyriar @connor4312 @meganrogge and others