Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programmatically created terminals are not automatically respecting the "defaultLocation" setting #127515

Closed
weinand opened this issue Jun 29, 2021 · 3 comments
Closed

Programmatically created terminals are not automatically respecting the "defaultLocation" setting #127515

weinand opened this issue Jun 29, 2021 · 3 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Milestone
June 2021

Comments

@weinand
Copy link
Contributor

weinand commented Jun 29, 2021

Testing #127192

  • set "terminal.integrated.defaultLocation" to "editor"
  • create a simple node program and a corresponding launch.json
  • add "console": "integratedTerminal" to the launch config
  • F5

Observe: new terminal is created in panel, not in the editor group
@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2021

Related: #127357

@Tyriar Tyriar added this to the June 2021 milestone Jun 29, 2021
@weinand
Copy link
Contributor Author

weinand commented Jun 29, 2021

@Tyriar Is there anything in my code to make the terminal respecting the default location?

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-editors labels Jun 29, 2021
@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2021

I think this is something we can control completely, solving the problem generally so tasks and debug and any future terminal use just works. At the most it would be an extra arg in debug which I can add.

@Tyriar Tyriar closed this as completed in dc1e951 Jun 29, 2021
@roblourens roblourens added the verified Verification succeeded label Jul 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

No branches or pull requests
5 participants
@roblourens @weinand @Tyriar @meganrogge and others