Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running task with "terminal.integrated.defaultLocation": "editor" does show task terminal #127509

Closed
andreamah opened this issue Jun 29, 2021 · 2 comments
Closed

Running task with "terminal.integrated.defaultLocation": "editor" does show task terminal #127509

andreamah opened this issue Jun 29, 2021 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Milestone
June 2021

Comments

@andreamah
Copy link
Contributor

Testing #127192

Steps:

  1. Set "terminal.integrated.defaultLocation": "editor" in settings
  2. Run the custombuildscript 32 task from the task extension sample (or any custom task).
  3. The pseudoterminal does not appear anywhere.

It seems that the task is still running since the live server turns on with the live server task, but I'm not seeing any terminal popping up.
https://user-images.githubusercontent.com/31675041/123839537-7867e400-d8ca-11eb-8ee7-cb83bc800385.mp4
@Tyriar Tyriar added this to the June 2021 milestone Jun 29, 2021
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal General terminal issues that don't fall under another label terminal-editors labels Jun 29, 2021
@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2021

It looks like it is being created still, just not in the editor. Tasks just don't respect this setting currently. fyi @alexr00

@Tyriar Tyriar closed this as completed in dc1e951 Jun 29, 2021
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jul 1, 2021
@TylerLeonhardt
Copy link
Member

Looks good.

image

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

No branches or pull requests
5 participants
@Tyriar @TylerLeonhardt @meganrogge @andreamah and others