Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatusBarItem.tooltip2 codicon don't work in rich hover #127433

Closed
Tyriar opened this issue Jun 29, 2021 · 4 comments
Closed

StatusBarItem.tooltip2 codicon don't work in rich hover #127433

Tyriar opened this issue Jun 29, 2021 · 4 comments
Assignees

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2021

Testing #127372

It's called out in the test that it's meant to work but doesn't:

image

Enabling this might just be flipping a switch in the hover code?

Version: 1.58.0-insider (user setup)
Commit: cc52823
Date: 2021-06-29T06:27:32.843Z
Electron: 12.0.12
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Windows_NT x64 10.0.19042

@aeschli
Copy link
Contributor

aeschli commented Jun 29, 2021

@Tyriar When creating the MarkdownString, did you set supportThemeIcons ?

constructor(value?: string, supportThemeIcons?: boolean);

@Tyriar
Copy link
Member Author

Tyriar commented Jun 29, 2021

Oh, I looked for that:

image

Can we bump the vscode engine version of the status bar example if that's the issue?

@Tyriar
Copy link
Member Author

Tyriar commented Jun 29, 2021

Works with that 👍

@aeschli
Copy link
Contributor

aeschli commented Jul 2, 2021

Thanks

@aeschli aeschli closed this as completed Jul 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants