Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding an active tab line to the terminal tabs list #127360

Closed
Tyriar opened this issue Jun 28, 2021 · 2 comments
Closed

Consider adding an active tab line to the terminal tabs list #127360

Tyriar opened this issue Jun 28, 2021 · 2 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-tabs
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2021

One annoyance I've had with tabs is that it's sometimes difficult to tell what the active item is because we rely so much on the selection which can change (plus bugs can slip in like #127357).

How about using the editor's selected tab border color and overriding with a terminal-specific one if present?

image

@misolori what do you think? Note that I have it overlapping the sash right now which should be fine as long as it ignored pointer events.

@Tyriar Tyriar added polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-tabs labels Jun 28, 2021
@Tyriar Tyriar added this to the July 2021 milestone Jun 28, 2021
@miguelsolorio
Copy link
Contributor

yea this looks great. Also similar in notebooks, we also show a slightly thicker and offset indicator:

CleanShot 2021-06-28 at 12 09 40@2x

but i think what you show better mirrors the active panel/editor border

@Tyriar
Copy link
Member Author

Tyriar commented Jul 7, 2021

Unfortunately it wasn't really doable without a bunch of hacks to replace the existing sash line:

image

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-tabs
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @meganrogge @miguelsolorio and others