term quick access shows closed terminal editors

[Tyriar]

From @g3offrey in #10546 (comment)

Hello,

First of all I want to thank you @meganrogge and @Tyriar about the awesome job on terminal editors. This is literally a game changer for me 😍

I tried this feature a lot these last days, and I encountered an issue that I think is not mentioned here.
When I close terminal editors, they are not deleted from the listing when typing term in CMD+P palette.

I share you a gif that shows this issue.

Steps to reproduce :

1. Open clean and up-to-date "Code Insiders" instance
2. Create a bunch of terminal editors (either via command palette or drag and drop)
3. Close them using the bin / closing the editor or via "kill" command
4. Open CMD+P palette and type term
5. ⚠️ Closed terminal still appears here

If I can help you on this issue, don't hesitate to reach me.

Again, thank you for your work on this feature. ✌️

[Tyriar]

This can still happen, repro:

1. Drag a terminal into editor
2. Split it
3. Close the right side

1 terminal editor:

Showing 2:

[g3offrey]

Hi !

I just tested the fix and it works fine for the use cases mentioned here. Thank you !

However I found another weird use case when splitting a terminal editor using the button at the top right corner (the one used to split editors). Indeed if you close both terminal after splitting then using this button, you will still find one in the term listing 😅

[Tyriar]

Thanks a bunch for the follow up @g3offrey, I can repro. Hopefully this'll catch all the cases 🙂