Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal defaultLocation editor causes panel's + button to create in the editor #127099

Closed
Tyriar opened this issue Jun 24, 2021 · 3 comments · Fixed by #127178
Closed

Terminal defaultLocation editor causes panel's + button to create in the editor #127099

Tyriar opened this issue Jun 24, 2021 · 3 comments · Fixed by #127178
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Milestone
June 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 24, 2021

No description provided.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-editors labels Jun 24, 2021
@Tyriar Tyriar added this to the June 2021 milestone Jun 24, 2021
@meganrogge
Copy link
Contributor

meganrogge commented Jun 24, 2021 •
edited
Loading

The terminal commands NewWithProfile and Split are used for both the panel buttons and the commands in the CP (that we do want to use the defaultLocation for). Not sure how to differentiate between them - don't think we want to duplicate the actions. @Tyriar let me know what you think

@Tyriar
Copy link
Member Author

Tyriar commented Jun 25, 2021

Let's wait until after #126256 is done since that will likely add target support to the create commands

@meganrogge
Copy link
Contributor

Other reproes:

  • Ctrl / Cmd J to open the panel -> 🐛 terminal editor is created
  • focus the terminal editor, click the trash can on the panel , close the editor tab -> 🐛 a bunch of errors in the console

@meganrogge meganrogge mentioned this issue Jun 25, 2021
Merged
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-editors verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

improve terminal view/editor action delegation microsoft/vscode
4 participants
@Tyriar @rzhao271 @meganrogge and others