Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown hover in status bar: not working without specified command #126753

Closed
usernamehw opened this issue Jun 19, 2021 · 4 comments
Closed

Markdown hover in status bar: not working without specified command #126753

usernamehw opened this issue Jun 19, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-status Status bar
Milestone

Comments

@usernamehw
Copy link
Contributor

#126258

Custom hover is not shown if status bar item doesn't have a command (works only after uncommenting one line).

const __ = window.createStatusBarItem(StatusBarAlignment.Left, -9999);
__.text = 'test';
// __.command = '';// <<<<<
const md = new MarkdownString('[$(github)](https://github.com)', true);
md.isTrusted = true;
__.tooltip2 = md;
__.show();

Commit: 7dea6d7
OS: Windows_NT x64 10.0.19043

@usernamehw
Copy link
Contributor Author

/assign Tyriar

@aeschli
Copy link
Contributor

aeschli commented Jun 22, 2021

@bpasero pointer-events: none is set on the label container if a status bar entry has no command.
That prevents also hovers (including the native hover (title)

https://github.com/microsoft/vscode/blob/main/src/vs/workbench/browser/parts/statusbar/media/statusbarpart.css#L109

@aeschli aeschli assigned bpasero and unassigned aeschli Jun 22, 2021
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-status Status bar labels Jun 22, 2021
@bpasero bpasero added this to the June 2021 milestone Jun 22, 2021
@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Jun 24, 2021
@usernamehw
Copy link
Contributor Author

/verified

@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-status Status bar
Projects
None yet
Development

No branches or pull requests

6 participants
@bpasero @Tyriar @aeschli @usernamehw @mjbvz and others