Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test format on save #12639

Closed
2 tasks done
jrieken opened this issue Sep 26, 2016 · 4 comments
Closed
2 tasks done

Test format on save #12639

jrieken opened this issue Sep 26, 2016 · 4 comments
Assignees

Comments

@jrieken
Copy link
Member

jrieken commented Sep 26, 2016

Test for #12449

Complexity 2

We added support to format a document on save. Please test that

  • there is a setting editor.formatOnSave and that the setting is documented and a good fit
  • format on save won't work when auto save is on
  • format on save works with all the other save options (focus lost etc)
  • format on save produces the same result as the format action from the context-menu would
@jrieken jrieken added this to the September 2016 milestone Sep 26, 2016
@chrmarti
Copy link
Contributor

@jrieken I'm assuming this also covers #239.

@jrieken
Copy link
Member Author

jrieken commented Sep 26, 2016

@chrmarti I have added #12640 for that

@kieferrm
Copy link
Member

#12827 is the only "issue" I found with this feature.

@kieferrm kieferrm assigned alexdima and unassigned kieferrm and alexdima Sep 27, 2016
@bgashler1
Copy link
Contributor

bgashler1 commented Sep 27, 2016

@jrieken Small thing, I would just put a comma before the conjunction "and" so it's not a run-on sentence.
image

@bgashler1 bgashler1 assigned jrieken and unassigned bgashler1 Sep 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants