Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Editors: Support reconnect #126250

Closed
Tyriar opened this issue Jun 14, 2021 · 0 comments · Fixed by #126693
Closed

Terminal Editors: Support reconnect #126250

Tyriar opened this issue Jun 14, 2021 · 0 comments · Fixed by #126693
Assignees
@Tyriar @meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal General terminal issues that don't fall under another label terminal-editors
Milestone
June 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2021

Sub-task of #125514

  • Handle reconnect properly
  • Don't restore editors on restart, only reattach to the processes
  • Reconnected terminal editors shouldn't resize terminal processes unless the window size has changed
@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal General terminal issues that don't fall under another label terminal-tabs labels Jun 14, 2021
@Tyriar Tyriar added this to the June 2021 milestone Jun 14, 2021
@Tyriar Tyriar mentioned this issue Jun 14, 2021
Closed
27 tasks
@meganrogge meganrogge mentioned this issue Jun 18, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal General terminal issues that don't fall under another label terminal-editors
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

Reconnect to terminal editors on reload microsoft/vscode
3 participants
@Tyriar @meganrogge and others