Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borken color in typescirpt decorator, use token ":" #12307

Closed
leaxoy opened this issue Sep 20, 2016 · 3 comments
Closed

Borken color in typescirpt decorator, use token ":" #12307

leaxoy opened this issue Sep 20, 2016 · 3 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded

Comments

@leaxoy
Copy link

leaxoy commented Sep 20, 2016

  • VSCode Version: Code - Insiders 1.6.0-insider (0a0bfed, 2016-09-20T06:05:07.843Z)
  • OS Version: Darwin x64 16.0.0

Bad colorize in typescript.

  1. use decorator. and use : in decorator values.
  2. then color render will be broken
@chrmarti
Copy link
Contributor

Will need to check if fixed by microsoft/TypeScript-TmLanguage#257. @aeschli can I assign these to you? That larger fix seems to take some time before it will be available in a release.

@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues labels Sep 20, 2016
@sheetalkamat
Copy link
Member

decorator support is added in microsoft/TypeScript-TmLanguage#257

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 21, 2016

This seems to have been fixed by the new TS grammar

screen shot 2016-11-21 at 2 26 57 pm

@leaxoy please give vscode 1.7+ a try and let me know if you still see any syntax highlighting issues around decorators. Thanks.

@mjbvz mjbvz closed this as completed Nov 21, 2016
@dbaeumer dbaeumer added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dbaeumer @aeschli @sheetalkamat @leaxoy @chrmarti @mjbvz