Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"workspace.trustEnabled": true is overwritten by "workspace.trustEnabled": false in the .vscode/settings.json #120462

Closed
tamuratak opened this issue Apr 3, 2021 · 0 comments
Closed

"workspace.trustEnabled": true is overwritten by "workspace.trustEnabled": false in the .vscode/settings.json #120462

tamuratak opened this issue Apr 3, 2021 · 0 comments
Assignees
@lszomoru @sbatten
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Milestone
April 2021

Comments

@tamuratak
Copy link
Contributor

tamuratak commented Apr 3, 2021 •
edited
Loading

"workspace.trustEnabled": true is overwritten by "workspace.trustEnabled": false in the .vscode/settings.json. Related to #106488.

We should not trust .vscode/settings.json by default.

Version: 1.56.0-insider
Commit: 5500358
Date: 2021-04-02T05:13:17.592Z
Electron: 11.4.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Darwin x64 18.7.0

Steps to Reproduce:

  1. Set "workspace.trustEnabled": true in the global settings.json
  2. Set "workspace.trustEnabled": false in the ./repo/.vscode/settings.json
  3. Open the repo directory.
  4. VS Code Insiders does not ask us whether we trust the repo workspace.
@lszomoru lszomoru added the workspace-trust Trusted workspaces label Apr 5, 2021
@lszomoru lszomoru added this to the April 2021 milestone Apr 5, 2021
@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Apr 5, 2021
@sbatten sbatten closed this as completed in 18548e7 Apr 5, 2021
@bwateratmsft bwateratmsft mentioned this issue Apr 8, 2021
Closed
@jrieken jrieken added the verified Verification succeeded label Apr 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lszomoru lszomoru

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
5 participants
@jrieken @lszomoru @sbatten @tamuratak and others