Suggest widget fails to add import

[joaomoreno]

I hit this soooo often, and for soooo long, I am surprised no one else sees it:

1. In a TS file, type a symbol from another file
2. At the end, press Ctrl Space and select it with Enter to add it to the imports

🐛 TypeScript doesn't add any import statement.

I have a very hard time reproducing this, unfortunately. As I tried to repro for a recording I completely failed. @mjbvz Can you review the code here and see if there are any holes in the logic which might cause this?

cc @jrieken

[joaomoreno]

Yup

[mjbvz]

Is this in the latest insiders?

[joaomoreno]

Yeah, tho I hit this for at least 2+ months.

[mjbvz]

I should have mostly fixed this this iteration, which is likely why you are having trouble reproducing it

Can you share a specific repo where you still see it?

[joaomoreno]

I only ever saw this in microsoft/vscode. I can never repro on demand unfortunately...

[mjbvz]

Ok, I'm going to close this as a duplicate of #109439 then

If you find a specific case where this doesn't work, please let me know