Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor highlighting of typescript code #11398

Closed
wclr opened this issue Sep 1, 2016 · 5 comments
Closed

Poor highlighting of typescript code #11398

wclr opened this issue Sep 1, 2016 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster typescript Typescript support issues

Comments

@wclr
Copy link

wclr commented Sep 1, 2016

  • VSCode Version: insiders
  • OS Version: windows 10

Most of the code of my TS files are one colored:
image

image

Here is full code of the file: https://gist.github.com/whitecolor/1e31f9b33ec5c9de3ba6bec34eefb32f

@dbaeumer dbaeumer added the typescript Typescript support issues label Sep 1, 2016
@wclr
Copy link
Author

wclr commented Sep 4, 2016

See this thing because of method switch, comment is not higlighted:
image

HTTP.select()
    .map(success).switch()
   // .map(r => r.body)

Github seem to have a like syntax highlighting problems with TS 👎

@aeschli aeschli added the info-needed Issue requires more information from poster label Sep 7, 2016
@wclr
Copy link
Author

wclr commented Sep 13, 2016

It is there more info needed? Did you check this. I just wonder if everybody experience the same poor highlighting or I have some strange specifics in may code/settings?

@empz
Copy link

empz commented Sep 27, 2016

I'm pretty sure this will be fixed once the next VSCode version is released with the updated TextMate grammar files.

See this PR: microsoft/TypeScript-TmLanguage#270

@wclr
Copy link
Author

wclr commented Sep 27, 2016

Hope to see it soon in insiders.

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 21, 2016

I believe this is fixed by the new TS grammar in VSCode 1.7+:

screen shot 2016-11-21 at 2 34 22 pm
screen shot 2016-11-21 at 2 34 09 pm

Please give VSCode 1.7+ a try and let me know if you still notice any issues for TypeScript syntax highlighting. Thanks.

@mjbvz mjbvz closed this as completed Nov 21, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

5 participants