Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke tests do not run anymore #112543

Closed
bpasero opened this issue Dec 15, 2020 · 8 comments
Closed

Smoke tests do not run anymore #112543

bpasero opened this issue Dec 15, 2020 · 8 comments
Assignees

Comments

@bpasero
Copy link
Member

bpasero commented Dec 15, 2020

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=97127&view=logs&j=3792f238-f35e-5f82-0dbc-272432d9a0fb&t=07088cf7-fede-5f74-0d50-155edd53af7d&l=75

1) VSCode Smoke Tests (Electron)
       VSCode Smoke Tests (Electron)
         Multiroot
           "before all" hook for "shows results from all folders":
     Error: connect ENOENT /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp-8753Dj8xcDG4GS7L
      at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1141:16)

  2) VSCode Smoke Tests (Electron)
       VSCode Smoke Tests (Electron)
         Localization
           "before all" hook for "starts with 'DE' locale and verifies title and viewlets text is in German":
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/1/s/test/smoke/out/main.js)
      at listOnTimeout (internal/timers.js:549:17)
      at processTimers (internal/timers.js:492:7)
@joaomoreno
Copy link
Member

They do run, but are flaky. At some point you should just remove that orange flag @bpasero.

image

@joaomoreno
Copy link
Member

Here's my suggestion:

Given that we now run this build in CI and DevOps understands the semantics behind our test runs and failures, we will let this run for a longer time and fix according to analytics: the ones which fail more often should be fixed first. And so on and so forth.

image

@bpasero
Copy link
Member Author

bpasero commented Dec 15, 2020

@joaomoreno I filed this because of:

     Error: connect ENOENT /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp-8753Dj8xcDG4GS7L
      at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1141:16)

This is an error I have never seen before and thought it maybe related to recent build pipeline changes.

@bpasero
Copy link
Member Author

bpasero commented Dec 15, 2020

image

This was never the case until a few days ago, I never got pinged like this before so something must have changed.

@alexdima
Copy link
Member

alexdima commented Dec 15, 2020

@bpasero Is it possible that the scheduled macOS maintenance is affecting Azure as well? -- actions/runner-images#2247 . This could lead to slower machines, slower I/O, etc.

But from my side, I can confirm that I have only edited ci.yml which is a file which does not affect the smoke tests in any form.

@bpasero
Copy link
Member Author

bpasero commented Dec 15, 2020

Ok thanks for pointing that out, I will keep an eye how it goes during the week.

@joaomoreno
Copy link
Member

@joaomoreno I filed this because of:

     Error: connect ENOENT /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp-8753Dj8xcDG4GS7L
      at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1141:16)

This is an error I have never seen before and thought it maybe related to recent build pipeline changes.

Did you see it happen more than once? I could only find that build 🤔 the builds around that one all passed OK.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants
@joaomoreno @bpasero @alexdima and others