Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide users to set user.name and/or user.email if missing from git config #110880

Closed
eamodio opened this issue Nov 18, 2020 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Nov 18, 2020

No description provided.

@eamodio eamodio added the git GIT issues label Nov 18, 2020
@eamodio eamodio added this to the November 2020 milestone Nov 18, 2020
@eamodio eamodio self-assigned this Nov 18, 2020
@eamodio eamodio added the bug Issue identified by VS Code Team member as probable bug label Nov 30, 2020
@rzhao271 rzhao271 added the verification-steps-needed Steps to verify are needed for verification label Dec 2, 2020
@rzhao271
Copy link
Contributor

rzhao271 commented Dec 2, 2020

Adding verification-steps-needed since I'm not sure what the new behaviour should be.

Firstly, I was able to make a commit with a name but no email. GitHub allows this by writing name <> instead of name <someemail> in the log.

When both were missing, I remember getting an error, along with an option to view the log, where I can then see the "missing name" message.

@eamodio
Copy link
Contributor Author

eamodio commented Dec 3, 2020

Yeah, you should get the following:
image

If either user.name or user.email is missing from your git configuration.

@eamodio eamodio added verification-needed Verification of issue is requested and removed verification-steps-needed Steps to verify are needed for verification labels Dec 3, 2020
@rzhao271 rzhao271 added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@eamodio @rzhao271 and others