preLaunchTask does not fire on restart for "node" adapter

[osolo]

• VSCode Version: 1.47.3
• OS Version: Windows 10 1909

Steps to Reproduce:

1. Create an project that uses the node adapter. In my case I'm targeting Electron with Typescript.
2. Add a preLaunchTask
3. Run the application
4. Edit one of the .ts files, introduce a syntax error
5. Hit the Restart button on the toolbar or Ctrl+Shift+F5

Expected: Should complain about the syntax error.
Actual: Does not - reruns the app without executing the preLaunchTask.

I'm attaching a small sample project that demonstrates this problem: ts-test.zip

See also: #28979 which is an old, similar bug report. I don't know if this is a regression.

Does this issue occur when all extensions are disabled?: Yes. This happens on a fresh install.

[isidorn]

Works for me with latest VS Code insiders

@osolo can you repro using latest vscode insiders https://code.visualstudio.com/insiders/

[OzSolomon-MSFT]

@isidorn yes, I can repro this with the insiders build. What can I do to provide more information?

[isidorn]

It would be great to have a minimal possible repository which reproduces this. So we can just clone it from GitHub and see it repro on our machines.

[OzSolomon-MSFT]

@isidorn did you use the zipped sample project I attached to the but report? It's very basic. All you need to do is unzip it and run npm install.

[isidorn]

I tried with that sample and I can not reproduce the issue. Let me know what you are doing differently:

[OzSolomon-MSFT]

@isidorn I'm doing the exact same as you:

[isidorn]

Do you have the following setting set?

"debug.onTaskErrors": "debugAnyway" 

[OzSolomon-MSFT]

This is a fresh install. My user settings file is empty.

The default settings file has "debug.onTaskErrors": "prompt", so I'm assuming that's in effect.

[isidorn]

Then I suggest you F1 > developer tools > sources > put a breakpoint around here and try to investigate
Idealy the runTasks should get called.

Also you can try to reproduce with a very plain typescript sample, for exaple vscode starter extension.

[OzSolomon-MSFT]

It looks like inside restartSession the debugging session configuration is missing the preLaunchTask:

The session seems different than the one that is created in doCreateSession:

Does this help?

[isidorn]

Yeah, this helps. THanks a lot

@connor4312 can you change that you pass the preLaunchTask to child sessions? So when user restarts a child session this case is covered?
I am not sure why I can not repro this on the macOS.

[connor4312]

Indeed, this is the same as #102296.

Thanks for reporting the issue, it should be fixed in 1.48.0 later this week (and is already fixed on VS Code Insiders). That's probably why you can't reproduce it, Isi :)

/duplicate

[isidorn]

@connor4312 hmm but the user says that he can reproduce with insiders - that is what got me confuse, since I knew you fixed something in this area that is why I first asked for repro in insiders.

[connor4312]

Ah, okay, I missed that. @OzSolomon-MSFT can you set trace: true in your launch.json and share the resulting log (its location will be written in your debug console). That will help us see what's happening.

[OzSolomon-MSFT]

@connor4312 please find attached.
vscode-debugadapter-0.json.gz

[connor4312]

Ah, got it, thanks 🙂 We weren't passing the tasks down to deeply nested children.

[isidorn]

Great, thanks for fixing.
@OzSolomon-MSFT thanks for provoding all teh details.