Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal VSCODE_GIT_IPC_HANDLE warning triangle #102727

Closed
dbaileyut opened this issue Jul 16, 2020 · 6 comments
Closed

Terminal VSCODE_GIT_IPC_HANDLE warning triangle #102727

dbaileyut opened this issue Jul 16, 2020 · 6 comments
Assignees
Labels
api polish Cleanup and polish issue under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone

Comments

@dbaileyut
Copy link

  • VSCode Version: 1.48.0-insider (system setup) 5e5fa3e
  • OS Version: Windows 10 x64 10.0.19041

Steps to Reproduce:

  1. Launch VS Code insiders with --disable-extensions
  2. Open the terminal pane
  3. Not the warning that says:
Extensions want to make the following changes to the terminal's environment:

VSCODE_GIT_IPC_HANDLE=\\.\pipe\vscode-git-114c7062bd-sock

Does this issue occur when all extensions are disabled?: Yes

Git version: 2.27.0.windows.1
This occurs with CMD.exe or Powershell.exe as the default terminal

image
image

@Tyriar
Copy link
Member

Tyriar commented Jul 17, 2020

What's the issue?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jul 17, 2020
@dbaileyut
Copy link
Author

The warning triangle itself appearing in a default/out of box configuration. There doesn't appear to be any breaking behavior.

@Tyriar
Copy link
Member

Tyriar commented Jul 17, 2020

I think this is what enables git auth provided by VS Code

@Tyriar Tyriar assigned joaomoreno and unassigned Tyriar Jul 17, 2020
@Tyriar Tyriar removed the info-needed Issue requires more information from poster label Jul 17, 2020
@joaomoreno
Copy link
Member

This just appears to be a usability issue surrounding the feature and its UX, @Tyriar.

@GitProfAn
Copy link

Just to add my triangle message here. As recommended, I simple re-launch the active terminal.

+++

Extensions want to make the following changes to the terminal's environment:
VSCODE_GIT_IPC_HANDLE=\.\pipe\vscode-git-285b3099df-sock

VSCODE_GIT_IPC_HANDLE

@rzhao271 rzhao271 added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 4, 2020
@Tyriar
Copy link
Member

Tyriar commented Mar 11, 2021

I think the discoverability issue of this is mostly fixed with relaunch and the upcoming #118066, users shouldn't see the warning icon anywhere near as often after these.

@Tyriar Tyriar closed this as completed Mar 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api polish Cleanup and polish issue under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants