Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM Open and Open in New Window do the same thing #101404

Closed
Tyriar opened this issue Jun 30, 2020 · 3 comments
Closed

SCM Open and Open in New Window do the same thing #101404

Tyriar opened this issue Jun 30, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2020

Testing #101302

image

These do the same thing when "window.openFoldersInNewWindow": "on" is set. Open recent respects this only when not using modifiers:

image

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Jun 30, 2020
@joaomoreno joaomoreno added this to the July 2020 milestone Jun 30, 2020
@joaomoreno
Copy link
Member

@bpasero Is there any way to force vscode.openFolder to use the same window?

https://github.com/microsoft/vscode/blob/master/extensions/git/src/commands.ts#L766-L770

@bpasero
Copy link
Member

bpasero commented Jun 30, 2020

@joaomoreno should work if you pass { forceReuseWindow: true }

@Tyriar
Copy link
Member Author

Tyriar commented Jun 30, 2020

Also consider swapping the "Open" action based on the setting as well, eg the buttons could be either "Open" and "Open in New Window", or "Open" and "Open in This Window".

@Tyriar Tyriar added the verified Verification succeeded label Aug 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@joaomoreno @bpasero @Tyriar and others