-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce compact flag to DebugSessionOptions #100852
Comments
Feedback from api call: it is fine to introduce the option as proposed and then next milestone we will see if debug extensions actually use it, and if nobody wants it we remove it. |
I have introduced a We wanted to make it negative, since the default that it is not specified should be the same as |
Since we have added this api as proposed and created a test plan item, I am moving this out to on-deck for finalisation. |
We have renamed this flag to be called |
We plan to finalize this API this August milestone. Just in case there is more feedback before we finalize it. fyi @connor4312 |
I've adopted this in js-debug, no real complaints. I had to change some behavior since certain interactions now always target the child, but these were my problems. |
The current JS Doc comment on the
Feedback from API sync: "We should make it more clear in the comment that the parent and the child session are actually rendered together since some actions (like stop) might be executed on the parent." For now I will not change the comment. But @connor4312 and @weinand let me know what you think and if you would like me to change the comment. |
I have finalized this API and have created this test plan item to cover the finalisation #104986 |
Refs: #99736
We are now compressing debug sessions in the call stack view when there is only one child session.
Since this behavior might not be ideal for all debug extension out of safety we would like to introduce a new flag
noCompact
to the DebugSessionOptions.If the option is not specified would be the same as
false
and thus we would compact the sessions.fyi @jrieken
The text was updated successfully, but these errors were encountered: