Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debt] improve the internals of the suggestion contribution #1006

Closed
3 tasks done
jrieken opened this issue Dec 4, 2015 · 7 comments
Closed
3 tasks done

[debt] improve the internals of the suggestion contribution #1006

jrieken opened this issue Dec 4, 2015 · 7 comments
Assignees
@jrieken
Labels
debt Code quality issues

Comments

@jrieken
Copy link
Member

jrieken commented Dec 4, 2015

Over the years we have accumulated debt in the internals of the suggest feature. Let's collect what we have already cleaned up and what left to do.

  • move overwiteBefore and overwriteAfter from ISuggestResult to ISuggestion - @aeschli
  • remove Suggestion.highlights and move it correctly in to the view model
  • improv perf when filtering down a list of suggestion by using the tree properly - @joaomoreno
@jrieken
Copy link
Member Author

jrieken commented Dec 4, 2015

@aeschli I'd be nice if you can update the html and JSON intellisense to use the textEdit

@joaomoreno
Copy link
Member

👍

@jrieken
Copy link
Member Author

jrieken commented Dec 4, 2015

@joaomoreno i have fixed the problem of disappearing highlights when focusing a suggestion

@egamma egamma mentioned this issue Dec 4, 2015
Closed
34 tasks
@joaomoreno joaomoreno mentioned this issue Dec 8, 2015
Merged
3 tasks
@egamma egamma added the debt Code quality issues label Dec 8, 2015
@egamma egamma added this to the Dec 2015 milestone Dec 8, 2015
@joaomoreno joaomoreno assigned aeschli and unassigned joaomoreno Dec 9, 2015
@joaomoreno
Copy link
Member

@aeschli Only overwriteBefore and overwriteAfter left...!

@aeschli
Copy link
Contributor

aeschli commented Dec 9, 2015

@joaomoreno I'll work on it ASAP

@jrieken
Copy link
Member Author

jrieken commented Dec 9, 2015

💃

@egamma egamma mentioned this issue Dec 10, 2015
Closed
18 tasks
@aeschli aeschli assigned jrieken and unassigned aeschli Dec 11, 2015
@aeschli
Copy link
Contributor

aeschli commented Dec 11, 2015

I moved overwiteBefore and overwriteAfter from ISuggestResult to ISuggestion.
Removed the textEdit on ISuggestion again.
As a last step we can look into removing currentWord and replace it with overwiteBefore

@jrieken jrieken modified the milestones: Jan 2016, Dec 2015 Dec 14, 2015
@egamma egamma mentioned this issue Jan 6, 2016
Closed
59 tasks
@jrieken jrieken removed this from the Jan 2016 milestone Jan 25, 2016
@jrieken jrieken closed this as completed Apr 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joaomoreno @egamma @jrieken @aeschli