From de63c37674e906dc10398537d992931b4bf5a735 Mon Sep 17 00:00:00 2001
From: Johannes Rieken <johannes.rieken@gmail.com>
Date: Tue, 15 Jun 2021 11:07:00 +0200
Subject: [PATCH] rename parameter to signature,
 https://github.com/microsoft/vscode/issues/39441

---
 src/vs/editor/common/modes.ts                          | 2 +-
 src/vs/editor/contrib/suggest/suggestWidgetRenderer.ts | 4 ++--
 src/vs/monaco.d.ts                                     | 2 +-
 src/vs/vscode.proposed.d.ts                            | 3 +--
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/vs/editor/common/modes.ts b/src/vs/editor/common/modes.ts
index f42c4ee03075f..76b00784ef481 100644
--- a/src/vs/editor/common/modes.ts
+++ b/src/vs/editor/common/modes.ts
@@ -495,7 +495,7 @@ export interface CompletionItemLabel {
 	/**
 	 * The parameters without the return type. Render after `name`.
 	 */
-	parameters?: string;
+	signature?: string;
 
 	/**
 	 * The fully qualified name, like package name or file path. Rendered after `signature`.
diff --git a/src/vs/editor/contrib/suggest/suggestWidgetRenderer.ts b/src/vs/editor/contrib/suggest/suggestWidgetRenderer.ts
index 0eae16979859e..b466ee9feb14b 100644
--- a/src/vs/editor/contrib/suggest/suggestWidgetRenderer.ts
+++ b/src/vs/editor/contrib/suggest/suggestWidgetRenderer.ts
@@ -213,11 +213,11 @@ export class ItemRenderer implements IListRenderer<CompletionItem, ISuggestionTe
 			data.root.classList.add('string-label');
 			data.root.title = '';
 		} else {
-			data.parametersLabel.textContent = stripNewLines(completion.label.parameters || '');
+			data.parametersLabel.textContent = stripNewLines(completion.label.signature || '');
 			data.qualifierLabel.textContent = stripNewLines(completion.label.qualifier || '');
 			data.detailsLabel.textContent = stripNewLines(completion.label.type || '');
 			data.root.classList.remove('string-label');
-			data.root.title = `${element.textLabel}${completion.label.parameters ?? ''}  ${completion.label.qualifier ?? ''}  ${completion.label.type ?? ''}`;
+			data.root.title = `${element.textLabel}${completion.label.signature ?? ''}  ${completion.label.qualifier ?? ''}  ${completion.label.type ?? ''}`;
 		}
 
 		if (this._editor.getOption(EditorOption.suggest).showInlineDetails) {
diff --git a/src/vs/monaco.d.ts b/src/vs/monaco.d.ts
index 2b8c3885dfa1a..9fdce8251e7ac 100644
--- a/src/vs/monaco.d.ts
+++ b/src/vs/monaco.d.ts
@@ -5669,7 +5669,7 @@ declare namespace monaco.languages {
 		/**
 		 * The parameters without the return type. Render after `name`.
 		 */
-		parameters?: string;
+		signature?: string;
 		/**
 		 * The fully qualified name, like package name or file path. Rendered after `signature`.
 		 */
diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts
index 7da4d2b93ab5e..429655c3e18a4 100644
--- a/src/vs/vscode.proposed.d.ts
+++ b/src/vs/vscode.proposed.d.ts
@@ -1389,8 +1389,7 @@ declare module 'vscode' {
 		/**
 		 * The parameters without the return type. Render after `name`.
 		 */
-		//todo@API rename to signature
-		parameters?: string;
+		signature?: string;
 
 		/**
 		 * The fully qualified name, like package name or file path. Rendered after `signature`.