From 6ab9dcec2e53982b99bb27c3f8679e881c605a38 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Mon, 28 Jun 2021 06:27:59 -0700 Subject: [PATCH] Remove instances from term editor service on dispose Fixes #127307 --- .../workbench/contrib/terminal/browser/terminalEditorService.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalEditorService.ts b/src/vs/workbench/contrib/terminal/browser/terminalEditorService.ts index f38846b025dfd..353cdc012783d 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalEditorService.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalEditorService.ts @@ -63,6 +63,7 @@ export class TerminalEditorService extends Disposable implements ITerminalEditor this.instances.push(unknownEditor.terminalInstance); } })); + this._register(this.onDidDisposeInstance(instance => this.detachInstance(instance))); } private _getActiveTerminalEditors(): IEditorInput[] {