UNC allow list checks cannot be disabled in extension host (fix #184989…

…) (#185085) * UNC allow list checks cannot be disabled in extension host (#184989) * Update src/vs/base/node/unc.js Co-authored-by: Robo <[email protected]> --------- Co-authored-by: Robo <[email protected]>
microsoft · Jun 14, 2023 · 695af09 · Grumpy2869 · Jul 2, 2023 · Grumpy2869
1 parent 4f95907
commit 695af09
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/src/vs/base/node/unc.d.ts b/src/vs/base/node/unc.d.ts
@@ -23,3 +23,8 @@ export function addUNCHostToAllowlist(allowedHost: string | string[]): void;
  * path validation.
  */
 export function disableUNCAccessRestrictions(): void;
+
+/**
+ * Whether UNC Host allow list in node.js is disabled.
+ */
+export function isUNCAccessRestrictionsDisabled(): boolean;
diff --git a/src/vs/base/node/unc.js b/src/vs/base/node/unc.js
@@ -117,11 +117,20 @@
 			process.enableUNCAccessChecks = false;
 		}
 
+		function isUNCAccessRestrictionsDisabled() {
+			if (process.platform !== 'win32') {
+				return true;
+			}
+
+			return process.enableUNCAccessChecks === false;
+		}
+
 		return {
 			getUNCHostAllowlist,
 			addUNCHostToAllowlist,
 			getUNCHost,
-			disableUNCAccessRestrictions
+			disableUNCAccessRestrictions,
+			isUNCAccessRestrictionsDisabled
 		};
 	}
 

diff --git a/src/vs/platform/utilityProcess/electron-main/utilityProcess.ts b/src/vs/platform/utilityProcess/electron-main/utilityProcess.ts
@@ -17,7 +17,7 @@ import { ILifecycleMainService } from 'vs/platform/lifecycle/electron-main/lifec
 import { removeDangerousEnvVariables } from 'vs/base/common/processes';
 import { deepClone } from 'vs/base/common/objects';
 import { isWindows } from 'vs/base/common/platform';
-import { getUNCHostAllowlist } from 'vs/base/node/unc';
+import { isUNCAccessRestrictionsDisabled, getUNCHostAllowlist } from 'vs/base/node/unc';
 
 export interface IUtilityProcessConfiguration {
 
@@ -259,7 +259,11 @@ export class UtilityProcess extends Disposable {
 		}
 		env['VSCODE_CRASH_REPORTER_PROCESS_TYPE'] = configuration.type;
 		if (isWindows) {
-			env['NODE_UNC_HOST_ALLOWLIST'] = getUNCHostAllowlist().join('\\');
+			if (isUNCAccessRestrictionsDisabled()) {
+				env['NODE_DISABLE_UNC_ACCESS_CHECKS'] = '1';
+			} else {
+				env['NODE_UNC_HOST_ALLOWLIST'] = getUNCHostAllowlist().join('\\');
+			}
 		}
 
 		// Remove any environment variables that are not allowed